Skip to content

[5.4] fix "build complete" message #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2021

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented May 7, 2021

brings #3313, #3352, #3353 to 5.4

rdar://77669218

@tomerd
Copy link
Contributor Author

tomerd commented May 7, 2021

@swift-ci please test

motivation: print "build complete" message reliably

changes:
* move the logic to printg the "build complete" message to the build complete handler
* add tests

rdar://77669218
@tomerd tomerd force-pushed the 5.4/build-complete branch from ee75bdc to ff4d19a Compare May 7, 2021 20:05
@tomerd
Copy link
Contributor Author

tomerd commented May 7, 2021

@swift-ci please test

@tomerd
Copy link
Contributor Author

tomerd commented May 7, 2021

@shahmishal
Copy link
Member

@tomerd
Copy link
Contributor Author

tomerd commented May 7, 2021

@swift-ci please test

@tomerd
Copy link
Contributor Author

tomerd commented May 8, 2021

unrelated CI issue, @swift-ci please test Linux

@tomerd tomerd self-assigned this May 10, 2021
@tomerd tomerd merged commit a2c3d94 into swiftlang:release/5.4 May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants