Skip to content

Remove the vendored copy of TSC #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2020
Merged

Remove the vendored copy of TSC #2991

merged 1 commit into from
Nov 19, 2020

Conversation

neonichu
Copy link
Contributor

Supersedes #2898

swiftlang/swift-tools-support-core#148 adds a workspace for testing TSC changes together with SwiftPM and SourceKit-LSP. That will be used for PR testing in the future.

@neonichu neonichu mentioned this pull request Oct 21, 2020
Closed
@neonichu
Copy link
Contributor Author

swiftlang/sourcekit-lsp#305
@swift-ci please smoke test

@neonichu neonichu self-assigned this Oct 21, 2020
@neonichu
Copy link
Contributor Author

The LSP PR got deleted in the move to "main", I'll open a new one.

@neonichu
Copy link
Contributor Author

swiftlang/sourcekit-lsp#338
@swift-ci please smoke test

@benlangmuir benlangmuir mentioned this pull request Oct 21, 2020
Merged
@neonichu
Copy link
Contributor Author

We can land the SourceKit-LSP PR and this once swiftlang/swift-tools-support-core#148 has landed.

@neonichu
Copy link
Contributor Author

We need to work through some issues with the extended CI of TSC, happening on this PR: swiftlang/swift-tools-support-core#150

In the meantime, we have switched the CI to using a workspace, but are still only running the TSC unit tests.

@abertelrud abertelrud mentioned this pull request Oct 30, 2020
Merged
@neonichu
Copy link
Contributor Author

CI works now and is using the same setup as SwiftPM itself, in addition to running TSC tests. That way it also supports cross-repository testing etc. I'll update this PR and then merge this and the SourceKitLSP one.

@neonichu neonichu force-pushed the remove-vendored-tsc branch from f996c44 to e2732b9 Compare November 19, 2020 00:18
@neonichu
Copy link
Contributor Author

swiftlang/sourcekit-lsp#338
@swift-ci please smoke test

abertelrud
abertelrud approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@abertelrud abertelrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@neonichu neonichu merged commit 53c086c into swiftlang:main Nov 19, 2020
@neonichu neonichu deleted the remove-vendored-tsc branch November 19, 2020 19:34
@benlangmuir benlangmuir mentioned this pull request Nov 19, 2020
Merged
federicobucchi pushed a commit to federicobucchi/swift-package-manager that referenced this pull request Jan 6, 2021
@neonichu @federicobucchi
Remove the vendored copy of TSC (swiftlang#2991)
a49c618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@federicobucchi federicobucchi federicobucchi approved these changes

@abertelrud abertelrud abertelrud approved these changes

@aciidgh aciidgh Awaiting requested review from aciidgh

@friedbunny friedbunny Awaiting requested review from friedbunny

Assignees

@neonichu neonichu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neonichu @federicobucchi @abertelrud