Skip to content

WIP: Extended CI #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

WIP: Extended CI #150

wants to merge 1 commit into from

Conversation

neonichu
Copy link
Contributor

This opts TSC in to running SwiftPM and SourceKit-LSP tests as well. Since there are some CI-specific issues to work through, we need a PR to iterate on them.

This opts TSC in to running SwiftPM and SourceKit-LSP tests as well.
Since there are some CI-specific issues to work through, we need a PR to
iterate on them.
@neonichu
Copy link
Contributor Author

Continuation of #148

@neonichu
Copy link
Contributor Author

@neonichu
Copy link
Contributor Author

Linux issue is that any tests that are running an inferior swift build or swift test are not finding the PackageDescription module.

@neonichu
Copy link
Contributor Author

The macOS job is consistenly hanging in XcodeprojTests.XcodeProjectModelTests

@neonichu neonichu self-assigned this Oct 22, 2020
@neonichu
Copy link
Contributor Author

I wonder if the hang is related to what we were seeing in swiftlang/swift-package-manager#2842

@neonichu
Copy link
Contributor Author

neonichu commented Nov 6, 2020

Going to try bootstrap instead of swift-test for the SwiftPM tests, let's see if that makes a difference.

@neonichu
Copy link
Contributor Author

neonichu commented Nov 6, 2020

@swift-ci please test

4 similar comments
@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu
Copy link
Contributor Author

Build timed out (after 83 minutes). Marking the build as failed.

@neonichu
Copy link
Contributor Author

@swift-ci please test macOS

@neonichu
Copy link
Contributor Author

Nice, looks like using build-script works fine (the Linux failure isn't related).

@neonichu
Copy link
Contributor Author

@swift-ci please test linux

1 similar comment
@neonichu
Copy link
Contributor Author

@swift-ci please test linux

@neonichu
Copy link
Contributor Author

Seems as if the Linux build is broken somehow:

/home/buildnode/jenkins/workspace/pr-swift-tools-support-core-linux/branch-main/swift-corelibs-foundation/CoreFoundation/String.subproj/CFString.c:3552:100: error: use of undeclared identifier 'UCHAR_EMOJI_MODIFIER'

Not sure why we aren't seeing the same thing in SwiftPM's job, both should be identical now.

@MaxDesiatov
Copy link
Contributor

@swift-ci please test Linux platform

@neonichu
Copy link
Contributor Author

@swift-ci please test Linux

@neonichu
Copy link
Contributor Author

I understand the linux issue now, the CI script was using the macOS preset also for Linux will led to system ICU being used.

@neonichu
Copy link
Contributor Author

@swift-ci please test Linux

@neonichu
Copy link
Contributor Author

Great this passes now, so we can enable the extended CI in general and close this PR.

@neonichu
Copy link
Contributor Author

OK, this can be closed now.

@neonichu neonichu closed this Nov 19, 2020
@neonichu neonichu deleted the extended-ci branch November 19, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants