implement package-collections business logic #3028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
tomerd
commented
Nov 6, 2020
tomerd
commented
Nov 6, 2020
tomerd
commented
Nov 6, 2020
neonichu
reviewed
Nov 6, 2020
yim-lee
reviewed
Nov 6, 2020
Sources/PackageCollections/Storage/PackageCollectionsProfileStorage.swift
Outdated
Show resolved
Hide resolved
abertelrud
reviewed
Nov 6, 2020
neonichu
reviewed
Nov 6, 2020
neonichu
added a commit
to neonichu/swift-package-manager
that referenced
this pull request
Nov 6, 2020
This implements the proposed CLI for package-collections. Requires swiftlang#3028
|
@swift-ci please smoke test |
tomerd
force-pushed
the
feature/package-collections-2
branch
from
347f658 to
0076c14
Compare
|
@swift-ci please smoke test |
|
hmm test failures are because of API changes in TSC: swiftlang/swift-tools-support-core#152 |
|
@swift-ci please smoke test |
|
@yim-lee @abertelrud @neonichu this should be ready for final review / merge |
yim-lee
approved these changes
Nov 7, 2020
|
|
||
| extension PackageCollectionsModel.CollectionSourceType: Codable { |
There was a problem hiding this comment.
Is the whole purpose of this just to be able to throw UnknownType error?
There was a problem hiding this comment.
@yim-lee are you asking about the purpose of CollectionSourceType? If so, it for us to be able to support multiple type of providers. e.g. feed, index, etc
There was a problem hiding this comment.
Can we use synthesized conformance and remove this extension block?
There was a problem hiding this comment.
ah, I dont believe enums synthesize conformance. am I missing anything?
There was a problem hiding this comment.
It could if CollectionSourceType: String, Codable but not sure we want to add : String though.
abertelrud
approved these changes
Nov 9, 2020
|
@swift-ci please smoke test |
motivation: continue the implmentation of package-collections changes: * implemented PackageCollectionsProtocol which is the main business logic of the feature * added basic configuration model for the feature * added basic validation rules for collection source * simplfied model names to be shorter * added relevants tests Co-authored-by: Boris Bügling <[email protected]> Co-authored-by: Yim Lee <[email protected]>
tomerd
force-pushed
the
feature/package-collections-2
branch
from
808d351 to
c7fc365
Compare
|
@swift-ci please smoke test |
neonichu
approved these changes
Nov 10, 2020
neonichu
added a commit
to neonichu/swift-package-manager
that referenced
this pull request
Nov 12, 2020
This implements the proposed CLI for package-collections. Requires swiftlang#3028
neonichu
added a commit
to neonichu/swift-package-manager
that referenced
this pull request
Nov 20, 2020
This implements the proposed CLI for package-collections. Requires swiftlang#3028
neonichu
added a commit
to neonichu/swift-package-manager
that referenced
this pull request
Dec 11, 2020
This implements the proposed CLI for package-collections. Requires swiftlang#3028
neonichu
added a commit
that referenced
this pull request
Dec 11, 2020
* Add a new `swift-package-collections` CLI This implements the proposed CLI for package-collections. Requires #3028 * address feedback * address feedback and adopt to latest API * more feedback * Update with proposal changes * Fix output indentation and rename CLI tool * Fix JSON output and adopt `.makeWithDefaults()`
federicobucchi
pushed a commit
to federicobucchi/swift-package-manager
that referenced
this pull request
Jan 6, 2021
motivation: continue the implmentation of package-collections changes: * implemented PackageCollectionsProtocol which is the main business logic of the feature * added basic configuration model for the feature * added basic validation rules for collection source * simplfied model names to be shorter * added relevants tests Co-authored-by: Boris Bügling <[email protected]> Co-authored-by: Yim Lee <[email protected]>
federicobucchi
pushed a commit
to federicobucchi/swift-package-manager
that referenced
this pull request
Jan 6, 2021
* Add a new `swift-package-collections` CLI This implements the proposed CLI for package-collections. Requires swiftlang#3028 * address feedback * address feedback and adopt to latest API * more feedback * Update with proposal changes * Fix output indentation and rename CLI tool * Fix JSON output and adopt `.makeWithDefaults()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: continue the implmentation of package-collections
changes: