-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add a new swift-package-collections
CLI
#3030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
commented
Nov 6, 2020
yim-lee
reviewed
Nov 7, 2020
tomerd
reviewed
Nov 7, 2020
tomerd
reviewed
Nov 7, 2020
tomerd
reviewed
Nov 7, 2020
abertelrud
reviewed
Nov 7, 2020
abertelrud
reviewed
Nov 12, 2020
abertelrud
reviewed
Nov 12, 2020
abertelrud
reviewed
Nov 12, 2020
eace181
to
c4c51ab
Compare
@swift-ci please smoke test |
dfbf133
to
38f9dba
Compare
@swift-ci please smoke test |
abertelrud
approved these changes
Nov 21, 2020
This implements the proposed CLI for package-collections. Requires swiftlang#3028
38f9dba
to
5ce2df0
Compare
|
@swift-ci please smoke test |
tomerd
approved these changes
Dec 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, one small comment on JSON encoding
Some commands were also missing JSON support, fixed that as well now. |
@swift-ci please smoke test |
federicobucchi
pushed a commit
to federicobucchi/swift-package-manager
that referenced
this pull request
Jan 6, 2021
* Add a new `swift-package-collections` CLI This implements the proposed CLI for package-collections. Requires swiftlang#3028 * address feedback * address feedback and adopt to latest API * more feedback * Update with proposal changes * Fix output indentation and rename CLI tool * Fix JSON output and adopt `.makeWithDefaults()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the proposed CLI for package-collections.
Requires #3028