Skip to content

Add a new swift-package-collections CLI #3030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 11, 2020

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Nov 6, 2020

This implements the proposed CLI for package-collections.

Requires #3028

@neonichu neonichu requested review from tomerd and yim-lee November 6, 2020 23:32
@neonichu neonichu marked this pull request as draft November 6, 2020 23:32
@neonichu neonichu force-pushed the add-collections-cli branch from eace181 to c4c51ab Compare November 12, 2020 22:52
@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

@neonichu neonichu force-pushed the add-collections-cli branch from dfbf133 to 38f9dba Compare November 20, 2020 19:55
@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

@neonichu neonichu force-pushed the add-collections-cli branch from 38f9dba to 5ce2df0 Compare December 11, 2020 19:41
@neonichu neonichu marked this pull request as ready for review December 11, 2020 19:42
@neonichu
Copy link
Contributor Author

  • Fixed output formatting (we should be using PlainTextEncoder in the future, but it isn't quite obvious to me how we would omit optional/empty content, so I fixed up my handwritten output for now)
  • Updated naming of the CLI tool
  • Removed the tool from install in bootstrap since we do not want to ship it as part of 5.3

@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one small comment on JSON encoding

@neonichu
Copy link
Contributor Author

Some commands were also missing JSON support, fixed that as well now.

@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

@neonichu neonichu merged commit 9c0b1ff into swiftlang:main Dec 11, 2020
@neonichu neonichu deleted the add-collections-cli branch December 11, 2020 22:59
federicobucchi pushed a commit to federicobucchi/swift-package-manager that referenced this pull request Jan 6, 2021
* Add a new `swift-package-collections` CLI

This implements the proposed CLI for package-collections.

Requires swiftlang#3028

* address feedback

* address feedback and adopt to latest API

* more feedback

* Update with proposal changes

* Fix output indentation and rename CLI tool

* Fix JSON output and adopt `.makeWithDefaults()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants