Make SPMTestSupport not require the command line tools (so it can be used for libSwiftPMDataModel) #3029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, which in turn depends on Build, etc. This lets the subset of unit tests that doesn't actually require the command line tools to still be used to test libSwiftPMDataModel. The only real code change needed is to move two tests that are actually testing handling of command line arguments of the `swift-build` tool from BuildPlanTests to BuildToolTests.
abertelrud
requested review from
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
neonichu
approved these changes
Nov 6, 2020
mattt
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a dependency of the SPMTestSupport target on the Command target, which in turn depends on Build, etc. This lets the subset of unit tests that doesn't actually require the command line tools to still be used to test libSwiftPMDataModel.
The only real code change needed is to move two tests that are actually testing handling of command line arguments of the
swift-buildtool from BuildPlanTests to BuildToolTests. This is where it belonged anyway, architecturally, since it's testing command line arguments.