Skip to content

Make SPMTestSupport not require the command line tools (so it can be used for libSwiftPMDataModel) #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ let package = Package(
.target(
/** SwiftPM test support library */
name: "SPMTestSupport",
dependencies: ["SwiftToolsSupport-auto", "Basics", "TSCTestSupport", "PackageGraph", "PackageLoading", "SourceControl", "Commands", "XCBuildSupport"]),
dependencies: ["SwiftToolsSupport-auto", "Basics", "TSCTestSupport", "PackageGraph", "PackageLoading", "SourceControl", "Workspace", "Xcodeproj", "XCBuildSupport"]),

// MARK: SwiftPM tests

Expand Down
3 changes: 1 addition & 2 deletions Sources/SPMTestSupport/Resources.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@
*/

import TSCBasic
import Build
import SPMBuildCore
import Foundation
import Commands
import PackageLoading
import Workspace

Expand Down
1 change: 0 additions & 1 deletion Sources/SPMTestSupport/misc.swift
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import PackageModel
import SourceControl
import TSCUtility
import Workspace
import Commands

@_exported import TSCTestSupport

Expand Down
16 changes: 0 additions & 16 deletions Tests/BuildTests/BuildPlanTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2572,22 +2572,6 @@ final class BuildPlanTests: XCTestCase {
try testBinaryTargets(platform: "macos", arch: "arm64e", destinationTriple: arm64eTriple)
}

func testCreatingSanitizers() throws {
for sanitizer in Sanitizer.allCases {
XCTAssertEqual(sanitizer, try Sanitizer(argument: sanitizer.shortName))
}
}

func testInvalidSanitizer() throws {
do {
_ = try Sanitizer(argument: "invalid")
XCTFail("Should have failed to create Sanitizer")
} catch let error as ArgumentConversionError {
XCTAssertEqual(
error.description, "valid sanitizers: address, thread, undefined, scudo")
}
}

func testAddressSanitizer() throws {
try sanitizerTest(.address, expectedName: "address")
}
Expand Down
17 changes: 17 additions & 0 deletions Tests/CommandsTests/BuildToolTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import XCTest

import SPMTestSupport
import TSCBasic
import SPMBuildCore
import Commands
import Workspace

Expand Down Expand Up @@ -51,6 +52,22 @@ final class BuildToolTests: XCTestCase {
XCTAssert(try execute(["--version"]).stdout.contains("Swift Package Manager"))
}

func testCreatingSanitizers() throws {
for sanitizer in Sanitizer.allCases {
XCTAssertEqual(sanitizer, try Sanitizer(argument: sanitizer.shortName))
}
}

func testInvalidSanitizer() throws {
do {
_ = try Sanitizer(argument: "invalid")
XCTFail("Should have failed to create Sanitizer")
} catch let error as ArgumentConversionError {
XCTAssertEqual(
error.description, "valid sanitizers: address, thread, undefined, scudo")
}
}

func testBinPathAndSymlink() throws {
fixture(name: "ValidLayouts/SingleModule/ExecutableNew") { path in
let fullPath = resolveSymlinks(path)
Expand Down
1 change: 0 additions & 1 deletion Tests/WorkspaceTests/InitTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import SPMTestSupport
import TSCBasic
import PackageModel
import Workspace
import Commands

class InitTests: XCTestCase {

Expand Down
2 changes: 1 addition & 1 deletion Tests/XCBuildSupportTests/PIFBuilderTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import TSCBasic
import TSCUtility
import PackageModel
import PackageGraph
import Build
import SPMBuildCore
import XCBuildSupport
import SPMTestSupport

Expand Down
2 changes: 1 addition & 1 deletion Tests/XCBuildSupportTests/PIFTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import XCTest
import TSCBasic
import TSCUtility
import PackageModel
import Build
import SPMBuildCore
import XCBuildSupport
import SPMTestSupport

Expand Down
1 change: 0 additions & 1 deletion Tests/XcodeprojTests/FunctionalTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import XCTest

import TSCBasic
import Commands
import SPMTestSupport
import PackageModel
import TSCUtility
Expand Down