Rename "extension" to "plugin" in the implementation of SE-0303 to align with the proposal #3311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abertelrud
requested review from
friedbunny,
neonichu and
tomerd
as code owners
abertelrud
force-pushed
the
align-implementation-to-proposal-names
branch
from
3d1fc0d to
9ccee3d
Compare
abertelrud
changed the title
abertelrud
force-pushed
the
align-implementation-to-proposal-names
branch
3 times, most recently
from
c2cb3b7 to
bb6c969
Compare
|
@swift-ci please smoke test |
abertelrud
changed the title
abertelrud
changed the title
This is a fairly large diff but is just the renaming from "extension" to "plugin" and the related variables and comments. The name of the runtime library changes too, and some of the methods use different verbs that work better with the noun "plugin". In some cases there are temporary typealiases to ease transition for clients.
abertelrud
force-pushed
the
align-implementation-to-proposal-names
branch
from
bb6c969 to
df3aa06
Compare
|
@swift-ci please smoke test |
abertelrud
added
the
ready
tomerd
approved these changes
Feb 26, 2021
|
😅 |
|
:) This was a big one. Once the tests pass and this is merged, I'll move #3312 out of Draft since it will be much easier to review. That one and the upcoming PRs all stack on top of this one. |
friedbunny
added a commit
to swiftlang/swift-package-collection-generator
that referenced
this pull request
Mar 5, 2021
…ension` → `.plugin` renaming Fix a build failure caused by SwiftPM upstream renaming `ProductType.extension` to `ProductType.plugin` in swiftlang/swift-package-manager#3311. Note that SwiftPM's `PackageCollectionModel.V1` hasn't gotten this rename yet and still has `ProductType.extension`, which seems like a mismatch that probably needs to be resolved upstream (and then again here).
friedbunny
added a commit
that referenced
this pull request
Mar 5, 2021
Follow-up to #3311 where "extension" was renamed to "plugin". This commit makes that same change in `PackageCollectionModel.V1.ProductType` and other related sites.
abertelrud
pushed a commit
that referenced
this pull request
Mar 6, 2021
Follow-up to #3311 where "extension" was renamed to "plugin". This commit makes that same change in `PackageCollectionModel.V1.ProductType` and other related sites.
yim-lee
pushed a commit
to swiftlang/swift-package-collection-generator
that referenced
this pull request
Mar 6, 2021
…ension` → `.plugin` renaming (#21) * Update PackageCollectionModel.V1.ProductType init extension for `.extension` → `.plugin` renaming Fix a build failure caused by SwiftPM upstream renaming `ProductType.extension` to `ProductType.plugin` in swiftlang/swift-package-manager#3311. Note that SwiftPM's `PackageCollectionModel.V1` hasn't gotten this rename yet and still has `ProductType.extension`, which seems like a mismatch that probably needs to be resolved upstream (and then again here). * Adopt pending upstream change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename "extension" to "plugin" to align with the proposal SE-0303.
This is a fairly large diff but is just the renaming from "extension" to "plugin" and the related variables and comments. The name of the runtime library changes too, and some of the methods use different verbs that work better with the noun "plugin". In some cases there are temporary typealiases to ease transition for clients.
No change in functionality.