Skip to content

Rename straggling "extension" cases to "plugin" #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

friedbunny
Copy link
Member

Follow-up to #3311 where "extension" was renamed to "plugin" — this commit makes that same change in PackageCollectionModel.V1.ProductType and other related sites.

Motivation:

Update PackageCollectionModel.V1.ProductType to be consistent with PackageModel.V1.ProductType.

Modifications:

  • Renamed PackageCollectionModel.V1.ProductType case .extension to .plugin.
  • Fixed deprecation message in PluginInvocation.swift to point to correct replacement.

/cc @abertelrud @yim-lee

Follow-up to #3311 where "extension" was renamed to "plugin". This commit makes that same change in `PackageCollectionModel.V1.ProductType` and other related sites.
@friedbunny
Copy link
Member Author

@swift-ci please smoke test

Copy link
Contributor

@yim-lee yim-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @friedbunny!

@tomerd tomerd added the ready Author believes the PR is ready to be merged & any feedback has been addressed label Mar 6, 2021
Copy link
Contributor

@abertelrud abertelrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abertelrud abertelrud merged commit 4f8f01a into main Mar 6, 2021
@friedbunny friedbunny deleted the jason.wray/rename-some-extension-plugin-stragglers branch March 6, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Author believes the PR is ready to be merged & any feedback has been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants