[Collections] Should be able to delete a non-existent local collection #3401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: 1. Add a local collection 2. Delete or rename the local collection file 3. Try deleting the local collection Result: Error about local file not found Expected: Non-existent local collection deleted The `remove` collection subcommand calls `getCollection` API to fetch collection's name for displaying success message later. `getCollection` tries to fetch collection from storage, and if it's not found there, it fetches from the source directly. The error is caused by the source validation logic, which mistakenly is the first thing `getCollection` does but should really only be done when we need to fetch from the source.
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Result: Error about local file not found
Expected: Non-existent local collection deleted
The
removecollection subcommand callsgetCollectionAPI to fetch collection's name for displaying success message later.getCollectiontries to fetch collection from storage, and if it's not found there, it fetches from the source directly. The error is caused by the source validation logic, which mistakenly is the first thinggetCollectiondoes but should really only be done when we need to fetch from the source.