Skip to content

[Collections] Should be able to delete a non-existent local collection #3401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2021
Merged

[Collections] Should be able to delete a non-existent local collection #3401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Sources/PackageCollections/PackageCollections.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,13 +262,13 @@ public struct PackageCollections: PackageCollectionsProtocol {
return callback(.failure(PackageCollectionError.unsupportedPlatform))
}

if let errors = source.validate()?.errors() {
return callback(.failure(MultipleErrors(errors)))
}

self.storage.collections.get(identifier: .init(from: source)) { result in
switch result {
case .failure:
// The collection is not in storage. Validate the source before fetching it.
if let errors = source.validate()?.errors() {
return callback(.failure(MultipleErrors(errors)))
}
guard let provider = self.collectionProviders[source.type] else {
return callback(.failure(UnknownProvider(source.type)))
}
Expand Down