[Collections] Dedupe package versions in GitHub metadata #3504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Package metadata returned by GitHub API may contain duplicate entries for the same tag. e.g., https://github.com/vapor/postgres-nio releases 1.5.0 and 1.5.1. This causes `getPackageMetadata` API to crash. Modification: Dedupe versions/tags when we construct dictionary from GitHub package versions array.
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
reviewed
May 19, 2021
| @@ -794,7 +794,7 @@ final class SQLitePackageCollectionsStorage: PackageCollectionsStorage, Closable | |||
| return false | |||
| } | |||
| } | |||
| }) | |||
| } | |||
There was a problem hiding this comment.
yes, it was a swiftformat change but I've reverted it in this PR.
|
@swift-ci please smoke test |
tomerd
approved these changes
May 19, 2021
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
May 19, 2021
) Motivation: Package metadata returned by GitHub API may contain duplicate entries for the same tag. e.g., https://github.com/vapor/postgres-nio releases 1.5.0 and 1.5.1. This causes `getPackageMetadata` API to crash. Modification: Dedupe versions/tags when we construct dictionary from GitHub package versions array.
yim-lee
added a commit
that referenced
this pull request
May 19, 2021
Motivation: Package metadata returned by GitHub API may contain duplicate entries for the same tag. e.g., https://github.com/vapor/postgres-nio releases 1.5.0 and 1.5.1. This causes `getPackageMetadata` API to crash. Modification: Dedupe versions/tags when we construct dictionary from GitHub package versions array.
bitjammer
pushed a commit
to bitjammer/swift-package-manager
that referenced
this pull request
Jul 23, 2021
) Motivation: Package metadata returned by GitHub API may contain duplicate entries for the same tag. e.g., https://github.com/vapor/postgres-nio releases 1.5.0 and 1.5.1. This causes `getPackageMetadata` API to crash. Modification: Dedupe versions/tags when we construct dictionary from GitHub package versions array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Package metadata returned by GitHub API may contain duplicate entries for the same tag. e.g., https://github.com/vapor/postgres-nio releases 1.5.0 and 1.5.1. This causes
getPackageMetadataAPI to crash.Modification:
Dedupe versions/tags when we construct dictionary from GitHub package versions array.