Skip to content

[Collections] Dedupe package versions in GitHub metadata #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2021
Merged

[Collections] Dedupe package versions in GitHub metadata #3504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9262eaf
[Collections] Dedupe package versions in GitHub metadata
yim-lee May 18, 2021
eab329f
Undo swiftformat changes in SQLitePackageCollectionsStorage.swift
yim-lee May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/PackageCollections/PackageCollections.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ public struct PackageCollections: PackageCollectionsProtocol {
internal static func mergedPackageMetadata(package: Model.Package,
basicMetadata: Model.PackageBasicMetadata?) -> Model.Package {
// This dictionary contains recent releases and might not contain everything that's in package.versions.
let basicVersionMetadata = basicMetadata.map { Dictionary(uniqueKeysWithValues: $0.versions.map { ($0.version, $0) }) } ?? [:]
let basicVersionMetadata = basicMetadata.map { Dictionary($0.versions.map { ($0.version, $0) }, uniquingKeysWith: { first, _ in first }) } ?? [:]
var versions = package.versions.map { packageVersion -> Model.Package.Version in
let versionMetadata = basicVersionMetadata[packageVersion.version]
return .init(version: packageVersion.version,
Expand Down