[Collections] testPopulateTargetTrie sometimes gets stuck #3522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `PackageCollectionsStorageTests/testPopulateTargetTrie` gets stuck sometimes because `targetTrieReady` is already set and `callback` is only invoked in the body of `memoize`. https://ci.swift.org/job/oss-swift-package-ubuntu-20_04-aarch64/79/console Modifications: Rearrange logic in `populateTargetTrie` such that `callback` is invoked outside of `memoize` body. Also, add `populateTargetTrieLock` to prevent more than one thread from calling `memoize` at the same time.
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
reviewed
Jun 2, 2021
Sources/PackageCollections/Storage/SQLitePackageCollectionsStorage.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci please smoke test |
neonichu
approved these changes
Jun 2, 2021
tomerd
reviewed
Jun 2, 2021
Sources/PackageCollections/Storage/SQLitePackageCollectionsStorage.swift
Outdated
Show resolved
Hide resolved
tomerd
reviewed
Jun 2, 2021
Sources/PackageCollections/Storage/SQLitePackageCollectionsStorage.swift
Show resolved
Hide resolved
|
@swift-ci please smoke test |
tomerd
approved these changes
Jun 2, 2021
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Jun 3, 2021
…3522) Motivation: `PackageCollectionsStorageTests/testPopulateTargetTrie` gets stuck sometimes because `targetTrieReady` is already set and `callback` is only invoked in the body of `memoize`. https://ci.swift.org/job/oss-swift-package-ubuntu-20_04-aarch64/79/console Modifications: Rearrange logic in `populateTargetTrie` such that `callback` is invoked outside of `memoize` body. Also, add `populateTargetTrieLock` to prevent more than one thread from calling `memoize` at the same time.
yim-lee
added a commit
that referenced
this pull request
Jun 3, 2021
) Motivation: `PackageCollectionsStorageTests/testPopulateTargetTrie` gets stuck sometimes because `targetTrieReady` is already set and `callback` is only invoked in the body of `memoize`. https://ci.swift.org/job/oss-swift-package-ubuntu-20_04-aarch64/79/console Modifications: Rearrange logic in `populateTargetTrie` such that `callback` is invoked outside of `memoize` body. Also, add `populateTargetTrieLock` to prevent more than one thread from calling `memoize` at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
PackageCollectionsStorageTests/testPopulateTargetTriegets stuck sometimes becausetargetTrieReadyis already set andcallbackis only invoked in the body ofmemoize.https://ci.swift.org/job/oss-swift-package-ubuntu-20_04-aarch64/79/console
Modifications:
Rearrange logic in
populateTargetTriesuch thatcallbackis invoked outside ofmemoizebody.Also, add
populateTargetTrieLockto prevent more than one thread from callingmemoizeat the same time.