[5.5][Collections] testPopulateTargetTrie sometimes gets stuck #3523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3522) Motivation: `PackageCollectionsStorageTests/testPopulateTargetTrie` gets stuck sometimes because `targetTrieReady` is already set and `callback` is only invoked in the body of `memoize`. https://ci.swift.org/job/oss-swift-package-ubuntu-20_04-aarch64/79/console Modifications: Rearrange logic in `populateTargetTrie` such that `callback` is invoked outside of `memoize` body. Also, add `populateTargetTrieLock` to prevent more than one thread from calling `memoize` at the same time.
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
yim-lee
changed the title
yim-lee
changed the title
|
@swift-ci please test |
tomerd
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3522 for 5.5