SPMTestSupport should not depend on Build
#3551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
tomerd
approved these changes
Jun 14, 2021
In #3398, we introduced a way to check whether a compiler supports specific flags. This functionality relies on the Swift Driver and therefore the `Build` module which isn't available on all platforms and therefore shouldn't be used by `SPMTestSupport`. This change removes the dependency and replaces the check in tests with a check for the 5.5 Swift compiler instead.
neonichu
force-pushed
the
test-support-should-not-depend-on-build
branch
from
3cc6ba0 to
81d00ef
Compare
|
Looks like I reversed the condition accidentally for some tests 🥲 |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In #3398, we introduced a way to check whether a compiler supports specific flags. This functionality relies on the Swift Driver and therefore the
Buildmodule which isn't available on all platforms and therefore shouldn't be used bySPMTestSupport.For example, llbuild does not currently work on iOS and the Swift Driver doesn't support Windows at this time.
Moreover, we should also not proliferate use of the
Buildmodule to parts of the code base that should be separate from an actual build process, in order to keep the separation between the full SwiftPM library and the data model variant.Modifications:
This change removes the dependency and replaces the check in tests with a check for the 5.5 Swift compiler instead.
Result:
Tests can be compiled and run again on platforms that didn't support this.