Skip to content

Require macOS 10.15 and iOS 13 or later on Darwin #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

abertelrud
Copy link
Contributor

@abertelrud abertelrud commented Jun 15, 2021

Increase the minimum deployment target to macOS 10.15 and iOS 13 or later. This is required in order to take advantage the APIs required for Netrc support etc. Note that non-Darwin platforms are unaffected.

This also removes the environment variable introduced in #220.

@abertelrud
Copy link
Contributor Author

@swift-ci please test

@abertelrud abertelrud requested a review from benlangmuir June 15, 2021 21:36
Increase the minimum deployment target to macOS 10.15 and iOS 13 or later.  This is required in order to take advantage the APIs required for Netrc support etc.  Note that non-Darwin platforms are unaffected.
@abertelrud abertelrud force-pushed the eng/increase-minimum-deployment-targets branch from 671e717 to 0c64406 Compare June 15, 2021 21:38
@abertelrud
Copy link
Contributor Author

@swift-ci please test

@abertelrud abertelrud requested a review from shahmishal June 15, 2021 21:46
@abertelrud
Copy link
Contributor Author

The Linux issues look related to swiftlang/swift-package-manager#3551.

@neonichu
Copy link
Contributor

As far as I can see, the Linux job is using the 5.4.1 toolchain which shouldn't enable any of the tests that need -entry-point-function-name.

@abertelrud
Copy link
Contributor Author

@swift-ci please test linux

1 similar comment
@abertelrud
Copy link
Contributor Author

@swift-ci please test linux

@abertelrud
Copy link
Contributor Author

I think I know what's going on with the Linux error. Unless the headings are interleaved incorrectly with the command lines, it's the Wrapping AST for MyOtherLocalTool for debugging command that is failing. That is a Linux-specific task, and I wonder if that is affected by the renaming of the main symbol.

However, this feature (the ability to test executables) isn't new, and has been working on Linux for a long time. I suppose that the distinction between 5.4.1 and 5.5 could be at play here?

@neonichu
Copy link
Contributor

Still haven't been able to reproduce this failure myself with the same (or at least a very similar) configuration.

@abertelrud
Copy link
Contributor Author

Thanks for continuing to look at that failure. Since the regular feature works on a proper downloaded toolchain, I'd suspect that what's involved here is starting out with a 5.4.1 toolchain but then bootstrapping a 5.5 compiler on it. So in effect it's a mixture of the 5.4.1 and 5.5 tools.

@tomerd
Copy link
Contributor

tomerd commented Jun 25, 2021

@abertelrud @neonichu should this be merged?

@abertelrud
Copy link
Contributor Author

@abertelrud @neonichu should this be merged?

It should but it can't, because the Linux test is still failing for unrelated reasons. @neonichu has been looking into it.

@neonichu
Copy link
Contributor

@swift-ci please test linux

@tomerd
Copy link
Contributor

tomerd commented Jun 28, 2021

It should but it can't, because the Linux test is still failing for unrelated reasons. @neonichu has been looking into it.

@abertelrud lmk if we need to power-merge this

@neonichu
Copy link
Contributor

I think the build should pass now. I upgraded the base toolchain being used, that seems to have worked at least in #231

@abertelrud
Copy link
Contributor Author

I think the build should pass now. I upgraded the base toolchain being used, that seems to have worked at least in #231

Thanks, @neonichu. Kicking off another build.

@abertelrud
Copy link
Contributor Author

@swift-ci please test linux

@abertelrud
Copy link
Contributor Author

This is green now, so merging.

@abertelrud abertelrud merged commit 5e968d4 into main Jun 28, 2021
@neonichu neonichu deleted the eng/increase-minimum-deployment-targets branch June 28, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants