-
Notifications
You must be signed in to change notification settings - Fork 129
Require macOS 10.15 and iOS 13 or later on Darwin #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
Increase the minimum deployment target to macOS 10.15 and iOS 13 or later. This is required in order to take advantage the APIs required for Netrc support etc. Note that non-Darwin platforms are unaffected.
671e717
to
0c64406
Compare
@swift-ci please test |
The Linux issues look related to swiftlang/swift-package-manager#3551. |
As far as I can see, the Linux job is using the 5.4.1 toolchain which shouldn't enable any of the tests that need |
@swift-ci please test linux |
1 similar comment
@swift-ci please test linux |
I think I know what's going on with the Linux error. Unless the headings are interleaved incorrectly with the command lines, it's the However, this feature (the ability to test executables) isn't new, and has been working on Linux for a long time. I suppose that the distinction between 5.4.1 and 5.5 could be at play here? |
Still haven't been able to reproduce this failure myself with the same (or at least a very similar) configuration. |
Thanks for continuing to look at that failure. Since the regular feature works on a proper downloaded toolchain, I'd suspect that what's involved here is starting out with a 5.4.1 toolchain but then bootstrapping a 5.5 compiler on it. So in effect it's a mixture of the 5.4.1 and 5.5 tools. |
@abertelrud @neonichu should this be merged? |
It should but it can't, because the Linux test is still failing for unrelated reasons. @neonichu has been looking into it. |
@swift-ci please test linux |
@abertelrud lmk if we need to power-merge this |
I think the build should pass now. I upgraded the base toolchain being used, that seems to have worked at least in #231 |
@swift-ci please test linux |
This is green now, so merging. |
Increase the minimum deployment target to macOS 10.15 and iOS 13 or later. This is required in order to take advantage the APIs required for Netrc support etc. Note that non-Darwin platforms are unaffected.
This also removes the environment variable introduced in #220.