Basic OpenBSD support. #3572
Basic OpenBSD support. #3572
Conversation
3405691582
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
3405691582
force-pushed
the
OpenBSDSupport
branch
2 times, most recently
from
7bb860b to
60ce8aa
Compare
|
Set to 999.0. |
|
@swift-ci please smoke test |
|
swiftlang/swift-tools-support-core#228 |
3405691582
force-pushed
the
OpenBSDSupport
branch
from
60ce8aa to
16f3718
Compare
|
swiftlang/swift-tools-support-core#228 |
Pepper in the right conditionals throughout. The unversioned triple issue is still necessary for the bootstrap script (and only the bootstrap script) which we will deal with separately.
3405691582
force-pushed
the
OpenBSDSupport
branch
from
16f3718 to
64c12e4
Compare
|
Fixed the last broken test case. That should hopefully be all that's required. 🤞 I'm rerunning them locally but that takes some time. The other test run looks like it's not integrating the changes across projects, though? |
|
swiftlang/swift-tools-support-core#228 |
The self hosted jobs don't support cross-repo testing, but they aren't required to pass anyway. They mostly exist to get quick response from CI since the actual smoke tests can take a long time. |
|
@neonichu since smoke tests pass - can this and swiftlang/swift-tools-support-core#228 be merged? the cross-PR testing on the TSC side did not pass / work |
|
Yep, I think this can be merged. But I'd like to take a look at what exactly failed when doing a cross-repo test from the TSC side. |
|
TSC PR is merged now, so we can merge this as well. |
Pepper in the right conditionals throughout.
The unversioned triple issue is still necessary for the bootstrap script
(and only the bootstrap script) which we will deal with separately.
Motivation:
Permit SPM to build on this platform.
Modifications:
Sources/Basics/DispatchTimeInterval+Extensions.swift: add the platform to the#ifto make the extension availableSources/PackageCollections/Providers/JSONPackageCollectionProvider.swift: add the platform to the switch -- likely not required to build but we might as well extend this now we are enabling the platform.Sources/PackageDescription/SupportedPlatforms.swift: add the static var for the platform. Please let me know here if the 5.4 availability annotation needs revision here.Sources/PackageLoading/PlatformRegistry.swift: add to the known platform list.Sources/PackageModel/Platform.swift: add the static var for the platform.Sources/SPMBuildCore/BinaryTarget+Extensions.swift: indeed XCFrameworks is unsupportedSources/SPMBuildCore/BuildParameters.swift: add the case for BuildParameterscurrentPlatform.Utilities/bootstrap: required flags for a successful build since sqlite3 is not part of the base system, additional flags are required (but again, the unversioned triple problem remains).Tests/PackageCollectionsTests/Utility.swiftandTests/PackageLoadingTests/PackageBuilderTests.swiftmodified to match.Result: