Mark Platform.openbsd as available since 5.6
#3970
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abertelrud
added
the
ready
|
@swift-ci smoke test |
tomerd
previously approved these changes
Jan 4, 2022
tomerd
reviewed
Jan 4, 2022
tomerd
reviewed
Jan 4, 2022
|
That's a good question — I will take a look at the original PR. I just noticed it as being 999.0 when changing the command plugin APIs, but we should leave as 999.0 if there isn't actually any support. |
|
Looks like this was introduced in #3572, where the statement is that SwiftPM now builds on OpenBSD. But since that's not an officially supported platform AFAIK, probably the right thing is to leave it as an experimental feature at 999.0 (which means SwiftPM 5.6 won't support it, but main toolchains will). |
abertelrud
added
DO NOT MERGE
and removed
ready
|
Closing this PR, leaving the annotation as 999.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark
Platform.openbsdas available since 5.6.Motivation:
Allows this new enum to be used in packages marked with 5.6.
Modifications:
This will also be nominated to the
release/5.6branch.