fix a bug where resolved files lose package name case #3608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @neonichu |
neonichu
approved these changes
Jul 13, 2021
|
@swift-ci please smoke test |
motivation: fixing dar://52529014 and rdar://52529011 caused a regression in resolved files serialization in which package name lost its original form, causing slight difference between resolved files in 5.4 and 5.5 changes: udpate serialization code to correctly preserve the package original name when constructing the package ref from the mirrors
|
@swift-ci please smoke test |
tomerd
added
the
ready
tomerd
changed the title
abertelrud
approved these changes
Jul 14, 2021
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Jul 14, 2021
motivation: fixing dar://52529014 and rdar://52529011 caused a regression in resolved files serialization in which package name lost its original form, causing slight difference between resolved files in 5.4 and 5.5 changes: udpate serialization code to correctly preserve the package original name when constructing the package ref from the mirrors
xwu
changed the title
tomerd
added a commit
that referenced
this pull request
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: fixing dar://52529014 and rdar://52529011 caused a regression in resolved files serialization in which package name lost its original form, causing slight difference between resolved files in 5.4 and 5.5
changes: update serialization code to correctly preserve the package original name when constructing the package ref from the mirrors