Skip to content

fix a bug where resolved file loses package name case #3610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Jul 14, 2021

brings #3608 to 5.5

motivation: fixing dar://52529014 and rdar://52529011 caused a regression in resolved files serialization in which package name lost its original form, causing slight difference between resolved files in 5.4 and 5.5

changes: udpate serialization code to correctly preserve the package original name when constructing the package ref from the mirrors
@tomerd tomerd added ready Author believes the PR is ready to be merged & any feedback has been addressed 5.5 labels Jul 14, 2021
@tomerd
Copy link
Contributor Author

tomerd commented Jul 14, 2021

@swift-ci test

@xwu xwu changed the title fix a bug where resoved file looses package name case fix a bug where resolved file loses package name case Jul 14, 2021
@tomerd tomerd merged commit 0a3c84d into swiftlang:release/5.5 Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Author believes the PR is ready to be merged & any feedback has been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants