RFC: configuration utilities #3652
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
4 tasks
|
cc @yim-lee |
yim-lee
reviewed
Aug 9, 2021
mattt
reviewed
Aug 9, 2021
There was a problem hiding this comment.
Thanks for taking on this work, @tomerd. I'd be very happy to see the logic for configuration consolidated and refactored into a single, consistent API.
Overall, this is looking good. The only question I have is whether Configurations should be its own module, rather than part of the Workspace module. What would the benefit be of having a new module versus, for example, putting all of this in a Configuration subfolder within the Workspace module.
tomerd
force-pushed
the
feature/configuration
branch
3 times, most recently
from
38cb45e to
6310e79
Compare
motivation: with SE-0292 adding more configuration, refactor the configuration uttilities to their own module so they can be used consistently across the code changes: * create a new Configuration module * refactor Collections sources storage to use the configuration module * refactor Mirrors to use the configuraiton module * refactor netrc to use the configuraiton module * adjust and add tests
tomerd
force-pushed
the
feature/configuration
branch
from
6310e79 to
ffbaa1c
Compare
|
thanks for the reminder @mattt - I think we can call this done for this phase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: with SE-0292 adding more configuration, refactor the configuration uttilities to their own module so they can be used consistently across the code
changes: