enhance configuraiton for authentication providers #3672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
needs #3670 first |
tomerd
added
the
ready
neonichu
approved these changes
Aug 17, 2021
motivation: support custom authentican providers, not just netrc changes: * reafactor and seperate out the auth data model from the loading/saving mutation utility * adjust call sites * add tests
tomerd
force-pushed
the
refactor/configuration-netrc
branch
from
d1ab233 to
28ec2ee
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
ci infra issue?! @swift-ci please smoke test |
|
unrelated compiler crash @swift-ci please smoke test macOS |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: support custom authentican providers, not just netrc
changes: