Fix integration test for Xcode 13 #3686
Conversation
neonichu
requested review from
abertelrud,
friedbunny and
tomerd
as code owners
|
@swift-ci please smoke test |
|
feels more like this is something we should XFail rather than fix by changing the manifest? manifest seems legit afaict? |
|
Looks like the same issue exists in the |
|
@tomerd not sure about xfail, that would mean we won't test this functionality at all anymore until we fix this which might take a while if we decide the fix ends up being in XCBuild. I think we should change the manifest back once we figured out the issue, though. |
neonichu
force-pushed
the
fix-integration-test-for-xcode13
branch
from
3fd937b to
9c7ad94
Compare
|
@swift-ci please smoke test |
This fixes `Found multiple targets named 'FooLib'` which is happening in this test when using the XCBuild from Xcode 13. We should figure out separately what to do about that case, but for now it seems most practical to change the test in order to not block other work in SwiftPM.
neonichu
force-pushed
the
fix-integration-test-for-xcode13
branch
from
9c7ad94 to
28dfd8b
Compare
|
@swift-ci please smoke test |
| .library(name: "BarLib", type: .dynamic, targets: ["BarLib"]), | ||
| .library(name: "BarLibProduct", type: .dynamic, targets: ["BarLib"]), |
There was a problem hiding this comment.
Just a nitpick: Would it be valuable to add a FIXME comment to each of these changes? Just in case they get lost. And I think it helps other code readers understand that some cases are not covered in the test.
There was a problem hiding this comment.
Thanks, that's a good idea. I think I'll do that in a follow up, just to avoid having CI broken for longer.
This fixes
Found multiple targets named 'FooLib'which is happening in this test when using the XCBuild from Xcode 13. We should figure out separately what to do about that case, but for now it seems most practical to change the test in order to not block other work in SwiftPM.See #3684 for more context.