Disambiguate PIF target names

[neonichu]

A product can have the same name as a target in SwiftPM, but since we create a PIF target for each, we need to come up with a unique name for products.

rdar://82744792

[neonichu]

@swift-ci please smoke test

[neonichu]

We may need to transform argument values for cases where the user uses --product $NAME, but I first wanna see if more tests need adjustments and running them locally is pretty slow.

[neonichu]

The tests need adjustments for this change:

/Users/buildnode/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/Tests/XCBuildSupportTests/PIFBuilderTests.swift:444: error: -[XCBuildSupportTests.PIFBuilderTests testExecutableProducts] : XCTAssertEqual failed: ("foo_1EF26F7F_PackageProduct") is not equal to ("foo")

[neonichu]

@swift-ci please smoke test

[neonichu]

A couple of the integration tests are still failing.

[neonichu]

The odd thing is that locally, these tests seem to be passing 🤔

[neonichu]

The odd thing is that locally, these tests seem to be passing 🤔

Oh, that's because I have been running them incorrectly. What I did was use the inferior swift-test, but since the tests themselves shell out, they were still using the superior swift-test to actually perform the test.

[neonichu]

Looks like the problem here are the tests themselves? They try to refer to products using --target, but I guess we also need a way to translate the value of --product to its mangled name in the PIF.

There's also a potentially interesting concern of us not generating a PIF target for executable targets, but only for their products, so --target won't work for building an executable target since it won't be represented in the PIF at all.

[neonichu]

@swift-ci please smoke test