[5.5] Pass toolchain settings when using XCBuild #3725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
abertelrud,
friedbunny and
tomerd
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please test |
abertelrud
approved these changes
Sep 8, 2021
|
The self-hosted macOS job is failing because of the XCBuild compatibility I am fixing here #3716 So I think this can be merged, all the regular tests are passing and the self-hosted jobs wouldn't even typically be running for 5.5 jobs according to config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.5 cherry-pick of #3709