[5.6] Allow running tests from a command plugin (#4002) #4008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci please test |
tomerd
approved these changes
Jan 13, 2022
abertelrud
force-pushed
the
eng/5.6-running-tests-from-command-plugins
branch
from
91ab64f to
c49cf4a
Compare
This wraps up the last piece for SE-0332, including support for filtering and for capturing code coverage while the tests are running. This uses most of the same implementation that existed in a very specify way in SwiftTestTool.swift, factoring it out into a new shared TestingSupport.swift file and making it more generic. Future refactoring should move it down to a new module that provides the shared test support for use from everywhere. rdar://87529139 (cherry picked from commit d43183a)
abertelrud
force-pushed
the
eng/5.6-running-tests-from-command-plugins
branch
from
c49cf4a to
14a6f94
Compare
|
@swift-ci please test |
abertelrud
commented
Jan 13, 2022
| @@ -461,70 +461,6 @@ public struct SwiftTestTool: SwiftCommand { | |||
| } | |||
| } | |||
|
|
|||
| /// Locates XCTestHelper tool inside the libexec directory and bin directory. | |||
There was a problem hiding this comment.
This code is not removed but is moved out into a separate file where it can be used by both SwiftTestTool and SwiftPackageTool.
abertelrud
commented
Jan 13, 2022
| import Workspace | ||
|
|
||
|
|
||
| /// Internal helper functionality for the SwiftTestTool command and for the |
There was a problem hiding this comment.
This code is not new but is moved out from SwiftTestTool into a separate file where it can be used by both SwiftTestTool and SwiftPackageTool.
abertelrud
added
5.6
ready
airspeedswift
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #4002.
Explanation: This cherrypicks the change to allow package command plugins to run tests in SwiftPM and get the results back in structured form. This change is on the main branch but should be included in the 5.6 release as command plugins are available in SwiftPM 5.6 for the first time.
Scope of Issue: This applies to command plugins that want to use the
PackageManager.test(_:parameters:)function.Reason for Nominating to 5.6: This allows command plugins to use the new
PackageManager.test(_:parameters:)function in SE-0332.Risk: Low — the material changes affects only a new code path that was introduced for command plugins, so only plugins that use
PackageManager.test(_:parameters:)are affected.Reviewed By: @tomerd
Automated Testing: A new unit test verifies the information sent to the plugin.
Dependencies: None
Impact on CI: None
How to Verify: Create a command package plugin that calls
PackageManager.test(_:parameters:)and verify the return results. See the new unit test for an example.rdar://87529139