Allow running tests from a command plugin #4002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abertelrud
added
the
ready
|
@swift-ci smoke test |
abertelrud
commented
Jan 10, 2022
abertelrud
commented
Jan 10, 2022
abertelrud
commented
Jan 10, 2022
| @@ -223,12 +223,12 @@ public final class UserToolchain: Toolchain { | |||
|
|
|||
| /// Returns the path to llvm-cov tool. | |||
| public func getLLVMCov() throws -> AbsolutePath { | |||
| return try UserToolchain.getTool("llvm-cov", binDir: self.destination.binDir) | |||
| return try UserToolchain.getTool("llvm-cov", binDir: self.swiftCompilerPath.parentDirectory) | |||
There was a problem hiding this comment.
This one and the one below were actually wrong and didn't work in debug builds of SwiftPM, as these tools come from the toolchain and are not built by SwiftPM. The new code is the same as for the symbol graph extraction tool and the other similar tools.
abertelrud
commented
Jan 10, 2022
abertelrud
force-pushed
the
eng/running-tests-from-command-plugins
branch
from
dc18339 to
4b0827c
Compare
|
@swift-ci smoke test |
tomerd
reviewed
Jan 10, 2022
tomerd
reviewed
Jan 10, 2022
tomerd
approved these changes
Jan 11, 2022
|
FYI: Working on some of the other feedback here. Will mark as WIP while I do. Should be done later today. |
abertelrud
force-pushed
the
eng/running-tests-from-command-plugins
branch
from
144b938 to
50c1f05
Compare
|
@swift-ci smoke test |
tomerd
reviewed
Jan 12, 2022
tomerd
reviewed
Jan 12, 2022
This wraps up the last piece for SE-0332, including support for filtering and for capturing code coverage while the tests are running. This uses most of the same implementation that existed in a very specify way in SwiftTestTool.swift, factoring it out into a new shared TestingSupport.swift file and making it more generic. Future refactoring should move it down to a new module that provides the shared test support for use from everywhere.
abertelrud
force-pushed
the
eng/running-tests-from-command-plugins
branch
from
50c1f05 to
d43183a
Compare
|
@swift-ci smoke test |
tomerd
approved these changes
Jan 12, 2022
abertelrud
added a commit
to abertelrud/swift-package-manager
that referenced
this pull request
Jan 12, 2022
This wraps up the last piece for SE-0332, including support for filtering and for capturing code coverage while the tests are running. This uses most of the same implementation that existed in a very specify way in SwiftTestTool.swift, factoring it out into a new shared TestingSupport.swift file and making it more generic. Future refactoring should move it down to a new module that provides the shared test support for use from everywhere. (cherry picked from commit beac985)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps up the last piece for SE-0332, including support for filtering and for capturing code coverage while the tests are running.
Motivation:
This is specified in SE-0332 (it's the last part of SE-0332 that wasn't yet merged).
Modifications:
SwiftTestTool, reusing much of the implementation ofswift testSwiftTestToolmethods so they they can be invoked on request from plugins tooComment
This uses most of the same implementation that existed in a very specify way in SwiftTestTool.swift, factoring it out into a new shared
TestingSupport.swiftfile and making it more generic. Future refactoring should move it down to a new module that provides the shared test support for use from everywhere.