Skip to content

Increment SwiftArgumentParser dependency to 1.0.3 #4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

abertelrud
Copy link
Contributor

@abertelrud abertelrud commented Feb 1, 2022

Increment SwiftArgumentParser dependency to 1.0.3 to pull in a bug fix that would cause subcommand arguments to be folded into the parent command

Motivation:

We'd like to get the fix in apple/swift-argument-parser#397 in order to fix issues with swift run and swift plugin arguments. For example, swift package plugin foo --verbose would cause the --verbose to be applied to the parent command and not the plugin.

rdar://88097258

…x that would cause subcommand arguments to be folded into the parent command
@abertelrud abertelrud self-assigned this Feb 1, 2022
@abertelrud
Copy link
Contributor Author

@swift-ci please smoke test

@abertelrud
Copy link
Contributor Author

abertelrud commented Feb 1, 2022

Coordinating the related toolchain repositories as well:

swiftlang/swift#41126
swiftlang/swift-source-compat-suite#633

@abertelrud abertelrud added the ready Author believes the PR is ready to be merged & any feedback has been addressed label Feb 1, 2022
@abertelrud
Copy link
Contributor Author

This is awaiting a coordinated merge by @shahmishal since the toolchain also needs to be updated to use the same version.

@shahmishal shahmishal merged commit 7d7366b into swiftlang:main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Author believes the PR is ready to be merged & any feedback has been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants