--disable-sandbox didn't properly disable it for build tool plugin commands (just the plugins themselves)
#4283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
neonichu
approved these changes
Apr 4, 2022
|
Linux: Oh right, need to specialize the unit test for macOS because we're not yet sandboxing on other platforms. |
… tool plugin commands Not exactly sure when this failed, but the setting ended up not getting passed through in one of the refactorings a couple of weeks ago. There wasn't a unit test covering it, so this commit adds one. rdar://90955872
abertelrud
force-pushed
the
eng/couldnt-disable-sandbox-for-build-tool-commands
branch
from
2a12ea4 to
96183ed
Compare
|
@swift-ci please smoke test |
abertelrud
deleted the
eng/couldnt-disable-sandbox-for-build-tool-commands
branch
abertelrud
added a commit
to abertelrud/swift-package-manager
that referenced
this pull request
Apr 19, 2022
… tool plugin commands (swiftlang#4283) Not exactly sure when this failed, but the setting ended up not getting passed through in one of the refactorings a couple of weeks ago. There wasn't a unit test covering it, so this commit adds one. rdar://90955872 (cherry picked from commit 03df3ac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
At some point
--disable-sandboxseems to have stopped working for the commands run on behalf of plugins. This caused one of the source compatibility suite packages (the protobuf one) to fail.Not exactly sure when this broke, but the setting ended up not getting passed through in one of the refactorings a couple of weeks ago. There wasn't a unit test covering this so it wasn't noticed until the source compat suite broke. This commit adds a specific unit test for it.
Changes:
options.security.disableSandboxto the correspondingbuildParametersbitrdar://90955872
After merging this we should revert swiftlang/swift-source-compat-suite#652 which XFAILed the SwiftProtobuf package test.