Skip to content

Mark swift-protobuf-plugin-example as XFAIL until rdar://90955872 is fixed #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

abertelrud
Copy link
Contributor

Pull Request Description

This marks the swift-protobuf-plugin-example test as XFAIL. There seems to be a bug in which SwiftPM is no longer respecting --disable-sandbox for plugins, and this nesting of sandboxes causes the invocation of the package plugin to fail.

@abertelrud
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@abertelrud
Copy link
Contributor Author

Note that this only fails in the actual automation. When running ./runner.py locally per the instructions, it passes. And so marking it XFAIL will make it UPASS ("unexpected pass"?) locally — will that be a problem?

@shahmishal shahmishal merged commit 73d5574 into main Mar 29, 2022
@shahmishal shahmishal deleted the xfail-swiftpm-plugin-test branch March 29, 2022 17:41
@shahmishal
Copy link
Member

Note that this only fails in the actual automation. When running ./runner.py locally per the instructions, it passes. And so marking it XFAIL will make it UPASS ("unexpected pass"?) locally — will that be a problem?

this should be fine for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants