Skip to content

Module aliases override updates #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Module aliases override updates #5585

merged 2 commits into from
Jun 17, 2022

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Jun 13, 2022

  • Use alias value defined upstream as a key downstream for overriding and chain them
  • Add pre-chained aliases to targets when needed and show diags
    Resolves rdar://93445417, rdar://93218209

@elsh
Copy link
Contributor Author

elsh commented Jun 13, 2022

@swift-ci smoke test

Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit hard to follow all the changes, but adding new tests is great

- Use alias value defined upstream as a key downstream for overriding and chain them
- Add pre-chained aliases to targets when needed and show diags
Resolves rdar://93445417, rdar://93218209
@elsh
Copy link
Contributor Author

elsh commented Jun 17, 2022

@swift-ci smoke test

@elsh
Copy link
Contributor Author

elsh commented Jun 17, 2022

@swift-ci smoke test

@elsh elsh merged commit 21c53e9 into main Jun 17, 2022
@elsh elsh deleted the es-chain branch June 17, 2022 13:46
elsh added a commit that referenced this pull request Jun 17, 2022
- Use alias value defined upstream as a key downstream for overriding and chain them
- Add pre-chained aliases to targets when needed and show diags
Resolves rdar://93445417, rdar://93218209
elsh added a commit that referenced this pull request Jun 17, 2022
- Use alias value defined upstream as a key downstream for overriding and chain them
- Add pre-chained aliases to targets when needed and show diags
Resolves rdar://93445417, rdar://93218209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants