Validation of package products should check that a library product doesn't try to include executable targets #5625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
neonichu
reviewed
Jun 24, 2022
| @@ -56,6 +56,10 @@ extension Basics.Diagnostic { | |||
| .error("system library product \(product) shouldn't have a type and contain only one target") | |||
| } | |||
|
|
|||
| static func libraryProductWithExectuableTarget(product: String) -> Self { | |||
| .error("library product '\(product)' should not contain an executable target") | |||
There was a problem hiding this comment.
Should the message contain the name(s) of the executable targets? Would make it easier for folks to resolve the issue.
There was a problem hiding this comment.
I was trying to match the existing style but can add the target names to some of the other messages here that don't have it.
…esn't try to include executable targets Currently a library product that includes an executable target in its `targets` array only results in a warning. This was the best that could be done before `executableTarget` was introduced, since further checking was needed to see if a `target` was a library or executable target. Since we have explicit types now, we should promote this to an error since people are running into it and it's not clear what the problem is. This check is limited to tools version 5.7 or later. This change includes a new test fixture and unit test. rdar://95782540
abertelrud
force-pushed
the
eng/95782540-better-executable-checking
branch
from
1ea317b to
64834c5
Compare
|
@swift-ci please smoke test |
|
Added the target names to this new message. We can go back and add to the existing messages in a separate PR. |
tomerd
approved these changes
Jun 25, 2022
abertelrud
added a commit
to abertelrud/swift-package-manager
that referenced
this pull request
Jun 27, 2022
…uct doesn't try to include executable targets (swiftlang#5625) Currently a library product that includes an executable target in its `targets` array only results in a warning. This was the best that could be done before `executableTarget` was introduced, since further checking was needed to see if a `target` was a library or executable target. Since we have explicit types now, we should promote this to an error since people are running into it and it's not clear what the problem is. This check is limited to tools version 5.7 or later. This change includes a new test fixture and unit test. rdar://95782540 (cherry picked from commit 5bd3355)
abertelrud
added a commit
that referenced
this pull request
Jun 27, 2022
…uct doesn't try to include executable targets (#5625) (#5629) Currently a library product that includes an executable target in its `targets` array only results in a warning. This was the best that could be done before `executableTarget` was introduced, since further checking was needed to see if a `target` was a library or executable target. Since we have explicit types now, we should promote this to an error since people are running into it and it's not clear what the problem is. This check is limited to tools version 5.7 or later. This change includes a new test fixture and unit test. rdar://95782540 (cherry picked from commit 5bd3355)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a library product that includes an executable target in its
targetsarray only results in a warning. This was the best that could be done beforeexecutableTargetwas introduced, since further checking was needed to see if atargetwas a library or executable target. Since we have explicit types now, we should promote this to an error since people are running into it and it's not clear what the problem is.This check is limited to tools version 5.7 or later. This change includes a new test fixture and unit test.
rdar://95782540