[5.7] Validation of package products should check that a library product doesn't try to include executable targets (#5625) #5629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uct doesn't try to include executable targets (swiftlang#5625) Currently a library product that includes an executable target in its `targets` array only results in a warning. This was the best that could be done before `executableTarget` was introduced, since further checking was needed to see if a `target` was a library or executable target. Since we have explicit types now, we should promote this to an error since people are running into it and it's not clear what the problem is. This check is limited to tools version 5.7 or later. This change includes a new test fixture and unit test. rdar://95782540 (cherry picked from commit 5bd3355)
|
@swift-ci please smoke test |
abertelrud
added
the
ready
tomerd
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 5.7 nomination of #5625.
rdar://95782540
(cherry picked from commit 5bd3355)