Add diags for non-existing binary used by prebuild plugin #5834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves rdar://90442392
|
@swift-ci smoke test |
tomerd
reviewed
Oct 24, 2022
tomerd
reviewed
Oct 24, 2022
|
@swift-ci smoke test |
|
@swift-ci smoke test |
tomerd
reviewed
Oct 24, 2022
|
@swift-ci smoke test |
tomerd
reviewed
Oct 24, 2022
| var outputData = Data() | ||
| var diagnostics = [Basics.Diagnostic]() | ||
| var buildCommands = [BuildToolPluginInvocationResult.BuildCommand]() | ||
| var prebuildCommands = [BuildToolPluginInvocationResult.PrebuildCommand]() | ||
|
|
||
| init(delegateQueue: DispatchQueue, toolPaths: [AbsolutePath]) { | ||
| init(delegateQueue: DispatchQueue, toolPaths: [AbsolutePath], fileSystem: FileSystem) { |
There was a problem hiding this comment.
nit: make fileSystem the first argument (we usually so). otherwise looks great!
There was a problem hiding this comment.
Is there a reason why it's made to be the first argument in general?
tomerd
reviewed
Oct 24, 2022
tomerd
approved these changes
Oct 24, 2022
|
@swift-ci smoke test |
elsh
changed the title
neonichu
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add diags for non-existing binary used by prebuild plugin.
Add a test to verify a package with a plugin target no longer requires a non-plugin target.
Resolves rdar://90442392, rdar://86787091