`PackageGraph.computeTestTargetsForExecutableTargets() is incorrectly affected by plugin usage #5841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s()` incorrectly returns test mappings for plugin usage targets) A target's use of a plugin is represented as a kind of dependency, but this should not influence the test association. Otherwise every test that depends on a library that uses a plugin seems to be associated with every other target that uses the plugin.
|
@swift-ci please smoke test |
neonichu
approved these changes
Oct 25, 2022
|
This one doesn't look directly related to this change: |
|
Seeing the same in all the PRs actually... |
|
Probably same as rdar://problem/101582542, #5834 added some plugin tests that aren't guarded by |
|
@swift-ci please smoke test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A target's use of a plugin is represented as a kind of dependency, but this should not influence the test association. Otherwise every test that depends on a library that uses a plugin seems to be associated with every other target that uses the plugin.
Motivation
This function is returning wrong results, causing tests of targets that use plugins to be incorrectly associated with other targets that use those same plugins.
Modifications
rdar://101564030