Basics: make ObservabilityScope conform to Sendable
#6089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
neonichu
previously approved these changes
Jan 31, 2023
When implementing `async`-friendly `HTTPClient`, we need to make `FileSystem` conform to `Sendable`. That would imply some kind of locking in `FileSystem` implementation. A more straightforward approach seems to make those actors. Since `FileSystem` is used in many places through our codebase, let's make the transition incremental by introducing a new `protocol AsyncFileSystem` first, which requires conforming protocols to be actors.
Additionally, moved `HTTPClientHeaders`, `HTTPClientRequest`, and `HTTPClientResponse` to separate files for easier maintenance.
Also add `SendableTimeInterval` to use instead of `DispatchTimeInterval` in `HTTPClient`
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
|
@swift-ci smoke test |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Not sure how to fix the macOS self-hosted job error with old Xcode on CI, and it isn't reproducible locally with newer Xcode. Putting this into a draft state until macOS CI nodes are updated to newer Xcode and Swift versions. |
…xd/sendable-observability # Conflicts: # Sources/Basics/Concurrency/ThreadSafeArrayStore.swift # Sources/Basics/Concurrency/ThreadSafeBox.swift
This comment was marked as outdated.
This comment was marked as outdated.
|
@swift-ci smoke test |
|
@swift-ci test Windows |
|
@swift-ci smoke test linux |
|
@swift-ci test windows |
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6022.
Motivation:
New
actor HTTPClientcan't takeObservabilityScopeas an argument to its functions as it's notSendable. This is the only major API difference betweenHTTPClientandLegacyHTTPClient, which we'd like to resolve.Modifications:
Marked
SwiftToolObservabilityHandler.OutputHandler,ThreadSafeBox,ThreadSafeArrayStore, andThreadSafeKeyValueStoreeitherUnsafeSendableor@unchecked Sendable, depending on Swift version. MadeObservabilityMetadata: Sendableby requiring its keys and values to be sendable. Added additionalSendablerequirement onDiagnosticsHandler.Result:
This allows passing
ObservabilityScopeinstances toHTTPClient/execute.