-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Change executable template to use main.swift
#6197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please smoke test |
bitjammer
reviewed
Feb 28, 2023
The recent changes to templates switched this template away from using `@main` which seems to not be compatible with Xcode's build system. The only non-`@main` way for executables that is supported is naming the primary source file "main.swift", so that is what this PR does.
1f41b0f
to
b730d34
Compare
@swift-ci please smoke test |
main.swift
main.swift
bitjammer
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually verified that all generated packages build with swift build
and xcodebuild
.
yim-lee
pushed a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 28, 2023
The recent changes to templates switched this template away from using `@main` which seems to not be compatible with Xcode's build system. The only non-`@main` way for executables that is supported is naming the primary source file "main.swift", so that is what this PR does.
plemarquand
added a commit
to plemarquand/swift-package-manager
that referenced
this pull request
Mar 18, 2025
plemarquand
added a commit
to plemarquand/swift-package-manager
that referenced
this pull request
Mar 24, 2025
plemarquand
added a commit
that referenced
this pull request
Apr 3, 2025
…8371) ### Motivation: Since `@main` is the general purpose way of marking the entry point to executables, use it over top level code when generating an executable template. ### Modifications: Update the template output when the specified `--type` is executable. ### Result: The template is now: ```swift @main struct MyProject { static func main() { print("Hello, world!") } } ``` This patch reverts #6197 and partially reverts #6144 --------- Co-authored-by: David Nadoba <[email protected]> Co-authored-by: Joseph Heck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes to templates switched this template away from using
@main
which seems to not be compatible with Xcode's build system. The only non-@main
way for executables that is supported is naming the primary source file "main.swift", so that is what this PR does.