Remove uses of private API (String._contiguousUTF8) #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ddunbar Could you review, please? |
|
@swift-ci Please test |
|
👍 |
|
Linux builder error is unrelated. @aciidb0mb3r Thanks for the review! |
|
Can we leave some marker in the code that we no longer have a performant API to use here? In my testing, using _contiguousUTF8 was really important for getting decent performance out of the places where we use Strings, and I am worried that if we just ditch it without a replacement we won't remember to update this again once a new performant API becomes available. |
|
For tracking: #647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm about to remove this API in swiftlang/swift#4631
I could avoid removing this API for now, but a rewrite of String is coming, so this use will have to be removed then.