[swift-3.0-branch] Removing the usage of a private API #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
It's unfortunate that we don't have a performance test for the previous implementation. It would be very interesting to know what kind of performance hit we're looking at (if any) by simplifying the code in this way. Presumably the complexity of the code was incurred because of real performance issues. |
|
(Obviously, I'm not at all arguing against removing the use of private API — that's both good and necessary). |
|
Thanks @moiseev! I hadn't seen the earlier conversation. I also didn't realize (but should have) that this was just the branch PR for a previous master PR. |
|
Closing without merging: see justification here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for swiftlang/swift#4753
rdar://problem/28289426