[5.9] Support Target Grouping #6365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
- Allow opting out of package boundary - Default set to package boundary Resolves rdar://107454728
|
@swift-ci smoke test |
|
@swift-ci smoke test windows |
|
cherrypicked from main #6356 |
tomerd
approved these changes
Apr 4, 2023
nkcsgexi
approved these changes
Apr 4, 2023
DougGregor
reviewed
Apr 4, 2023
| @@ -16,12 +16,14 @@ public extension Target { | |||
| @available(_PackageDescription, introduced: 999.0) | |||
| static func macro( | |||
| name: String, | |||
| group: TargetGroup, | |||
There was a problem hiding this comment.
This breaks existing macro packages, and deviates from the API under review in SE-0394. Can we please make this optional?
This was referenced Apr 4, 2023
kishikawakatsumi
added a commit
to kishikawakatsumi/swift-power-assert
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Target Grouping
Resolves rdar://107454728