Skip to content

Set a default value to the group param for a macro target #6384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

Set a default value to the group param for a macro target #6384

merged 1 commit into from
Apr 5, 2023

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Apr 4, 2023 •
edited
Loading

Set a default value to the group param for a macro target to un-break macro packages per #6365

@elsh elsh requested a review from DougGregor April 4, 2023 22:18
@elsh
Copy link
Contributor Author

elsh commented Apr 4, 2023

@swift-ci smoke test

@elsh elsh mentioned this pull request Apr 4, 2023
Merged
@elsh elsh changed the title Make group param optional Make group param optional for a macro target Apr 4, 2023
tomerd
tomerd reviewed Apr 4, 2023
View reviewed changes
tomerd
tomerd suggested changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change still makes the argument required, I think it needs a default value

@elsh elsh changed the title Make group param optional for a macro target Set a default value to the group param for a macro target Apr 4, 2023
@elsh
Copy link
Contributor Author

elsh commented Apr 4, 2023

@swift-ci smoke test

@elsh elsh enabled auto-merge (squash) April 4, 2023 22:51
@elsh
Copy link
Contributor Author

elsh commented Apr 5, 2023

@swift-ci smoke test macOS

@elsh
Copy link
Contributor Author

elsh commented Apr 5, 2023

@swift-ci smoke test windows

@elsh elsh merged commit 9a0d0ce into main Apr 5, 2023
@tomerd tomerd deleted the es-opt branch May 1, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonichu neonichu neonichu approved these changes

@tomerd tomerd tomerd approved these changes

@DougGregor DougGregor DougGregor approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elsh @neonichu @tomerd @DougGregor