Don’t disable Swift 6 mode in swift-syntax #7545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shouldn’t be needed anymore with swiftlang#7504.
|
@swift-ci Please test |
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
May 9, 2024
When swiftlang/swift-package-manager#7545 is in, the `SWIFTSYNTAX_DISABLE_SWIFT_6_MODE` environment variable isn’t used anymore.
bnbarham
approved these changes
May 14, 2024
ahoppen
added a commit
that referenced
this pull request
May 14, 2024
* **Explanation**: Remove code that forced swift-syntax to be built in Swift 5 mode because the underlying issue was fixed by #7504 * **Scope**: Building SwiftPM * **Risk**: Low, if there are any issues, they will be caught at build time * **Testing**: Checked that SwiftPM still builds * **Issue**: n/a * **Reviewer**: @bnbarham on #7545
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
May 14, 2024
When swiftlang/swift-package-manager#7545 is in, the `SWIFTSYNTAX_DISABLE_SWIFT_6_MODE` environment variable isn’t used anymore.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
This shouldn’t be needed anymore with swiftlang#7504.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
This shouldn’t be needed anymore with swiftlang#7504.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn’t be needed anymore with #7504.