Don’t disable Swift 6 mode in swift-syntax #7558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahoppen
commented
May 14, 2024
ahoppen
commented
- Explanation: Remove code that forced swift-syntax to be built in Swift 5 mode because the underlying issue was fixed by [6.0] Handle Swift versions unsupported by XCBuild #7504
- Scope: Building SwiftPM
- Risk: Low, if there are any issues, they will be caught at build time
- Testing: Checked that SwiftPM still builds
- Issue: n/a
- Reviewer: @bnbarham on Don’t disable Swift 6 mode in swift-syntax #7545
This shouldn’t be needed anymore with swiftlang#7504.
|
@swift-ci Please test |
bnbarham
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.