Add a test case for static products with a binary artifact dependency #8212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv and
bkhouri
as code owners
xedin
approved these changes
Jan 14, 2025
|
@swift-ci test |
|
FWIW I didn't test as it is going to fail without the other change 😅. I'll test once it's in (though it seems to be blocked on spurious failures...) |
|
@swift-ci please test |
Add a test swiftlang#8055 that checks we can successfully generate a manifest for a target -> static product -> binary artifact dependency.
bnbarham
force-pushed
the
product-with-artifact-dep
branch
from
86d7dba to
a11477e
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for #8055 that checks we can successfully generate a manifest for a target -> static product -> binary artifact dependency.