[6.1] Binary dependencies of C/C++ modules break build planning #8225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8056) Fix a regression where the build planning phase will early terminate if SwiftPM packages contain binary targets that C/C++ products refer to, swiftlang#8055. ### Motivation: When running `swift build` on SwiftPM packages with binary targets that C++ products refer to, they will early terminate during the build planning phase with the following error: ```swift error: InternalError(description: "Internal error. Please file a bug at https://github.com/swiftlang/swift-package-manager/issues with this info. unknown module: <ResolvedModule: Python, binary>") ``` ### Modifications: Remove the guard, so we do not fail ~~if the module dependency does not yet exist in the build plan's target map, which I think is normal~~ on binary targets that C++ products refer to, since they don't have build descriptions. ### Result: When running `swift build` on SwiftPM packages with binary targets that C++ products refer to, the build planning phase will proceed successfully without error. --------- Signed-off-by: furby™ <[email protected]> (cherry picked from commit 0c6acf3)
bnbarham
requested review from
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv and
bkhouri
as code owners
1 task
|
@swift-ci please test |
Add a test swiftlang#8055 that checks we can successfully generate a manifest for a target -> static product -> binary artifact dependency. (cherry picked from commit a11477e)
bnbarham
force-pushed
the
cherry-binary-dep-fix
branch
from
014f595 to
5abfd33
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
bkhouri
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes a regression between 6.0 and 6.1 where a C/C++ product depending on a binary artifact would cause an internal failure.
Scope: Packages
Risk: Low - this just removes a check that was incorrectly added post 6.0 (ie. reverts to the previous behavior)
Testing: New test for this specific case
Issue: #8055
Reviewer: @xedin
Original PR: #8056 and #8212