Rename remaining occurrences of the old helper.

[yyvch]

Rename remaining occurrences of the old helper.

Motivation:

My local test failed to build after #8569 with

…/Tests/WorkspaceTests/WorkspaceTests.swift:16148:13: error: cannot find 'skipOnWindowsAsTestCurrentlyFails' in scope
16146 | 
16147 |     func testInvalidTrait_WhenParentPackageEnablesTraits() async throws {
16148 |         try skipOnWindowsAsTestCurrentlyFails(because: #"\tmp\ws doesn't exist in file system"#)
      |             `- error: cannot find 'skipOnWindowsAsTestCurrentlyFails' in scope
16149 | 
16150 |         let sandbox = AbsolutePath("/tmp/ws/")

I checked, and it appears to be leftovers after #8569:

% rg skipOnWindowsAsTestCurrentlyFails
Tests/WorkspaceTests/WorkspaceTests.swift
16148:        try skipOnWindowsAsTestCurrentlyFails(because: #"\tmp\ws doesn't exist in file system"#)
16211:        try skipOnWindowsAsTestCurrentlyFails(because: #"\tmp\ws doesn't exist in file system"#)

Modifications:

Renamed skipOnWindowsAsTestCurrentlyFails to XCTSkipOnWindows.

Result:

Tests build and pass.

[yyvch]

@swift-ci please test

[bkhouri]

I wonder how this was missed! Sorry for impacting you!

[yyvch]

I wonder how this was missed!

Two in-flight PRs modifying the same file, pass individually but fail when merged:

• [Traits] Change TraitConfiguration to be an enum instead of struct #8370 introducing the two new calls for skipOnWindowsAsTestCurrentlyFails
• Tests: Merge Windows helper function and update GH issues #8569 renaming skipOnWindowsAsTestCurrentlyFails to XCTSkipOnWindows

[bnbarham]

Merging to unblock PR testing