Add static .nanoseconds(_: Double) to Duration #81210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SE-0329 defines the following static factory methods: ``` public static func seconds<T: BinaryInteger>(_ seconds: T) -> Duration public static func seconds(_ seconds: Double) -> Duration public static func milliseconds<T: BinaryInteger>(_ milliseconds: T) -> Duration public static func milliseconds(_ milliseconds: Double) -> Duration public static func microseconds<T: BinaryInteger>(_ microseconds: T) -> Duration public static func microseconds(_ microseconds: Double) -> Duration public static func nanoseconds<T: BinaryInteger>(_ value: T) -> Duration ``` For no good reason, the obvious additional method: ``` public static func nanoseconds(_ nanoseconds: Double) -> Duration ``` was omitted. After talking this through with the LSG, we have decided that this is simply a bug, and we will add this method without formal evolution review.
|
@swift-ci test |
phausler
approved these changes
Apr 30, 2025
|
swift-pm failure is unrelated and fixed here: swiftlang/swift-package-manager#8583 |
|
@swift-ci smoke test |
stephentyrone
added a commit
that referenced
this pull request
May 2, 2025
SE-0329 defines the following static factory methods: ``` public static func seconds<T: BinaryInteger>(_ seconds: T) -> Duration public static func seconds(_ seconds: Double) -> Duration public static func milliseconds<T: BinaryInteger>(_ milliseconds: T) -> Duration public static func milliseconds(_ milliseconds: Double) -> Duration public static func microseconds<T: BinaryInteger>(_ microseconds: T) -> Duration public static func microseconds(_ microseconds: Double) -> Duration public static func nanoseconds<T: BinaryInteger>(_ value: T) -> Duration ``` For no good reason, the obvious additional method: ``` public static func nanoseconds(_ nanoseconds: Double) -> Duration ``` was omitted. After talking this through with the LSG, we have decided that this is simply a bug, and we will add this method without formal evolution review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE-0329 defines the following static factory methods:
For no good reason, the obvious additional method:
was omitted. After talking this through with the LSG, we have decided that this is simply a bug, and we will add this method without formal evolution review.