Skip to content

Tests: Convert more tests to Swift Testing #8636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented May 8, 2025

Continue to test conversion to Swift Testing.

  • Tests/BasicsTests/HTTPClientTests.swift
  • Tests/BasicsTests/SQLiteBackedCacheTests.swift
  • Tests/BuildTests/BuildPlanTraversalTests.swift
  • Tests/BuildTests/LLBuildManifestBuilderTests.swift
  • Tests/BuildTests/SwiftCompilerOutputParserTests.swift
  • Tests/BuildTests/WindowsBuildPlanTests.swift
  • Tests/_AsyncFileSystemTests/AsyncFileSystemTests.swift

Continue to test conversion to Swift Testing.

- Tests/BasicsTests/HTTPClientTests.swift
- Tests/BasicsTests/SQLiteBackedCacheTests.swift
- Tests/BuildTests/BuildPlanTraversalTests.swift
- Tests/BuildTests/LLBuildManifestBuilderTests.swift
- Tests/BuildTests/SwiftCompilerOutputParserTests.swift
- Tests/BuildTests/WindowsBuildPlanTests.swift
- Tests/_AsyncFileSystemTests/AsyncFileSystemTests.swift
@bkhouri
Copy link
Contributor Author

bkhouri commented May 8, 2025

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented May 8, 2025

@swift-ci test linux

@bkhouri bkhouri enabled auto-merge (squash) May 8, 2025 14:49
@bkhouri bkhouri merged commit e5c210a into swiftlang:main May 8, 2025
6 checks passed
@drodriguez
Copy link
Contributor

Is the new dependency on swift-numerics used at all?

@bkhouri
Copy link
Contributor Author

bkhouri commented May 13, 2025

Is the new dependency on swift-numerics used at all?

It was going to be used in one of the tests to replace the the XCTAssertEquals(::accuracy) API per the Migrate From XCTest documentation.

Screenshot 2025-05-13 at 1 49 09 PM

But that test wasn't converted as the SwiftTesting version of it was "flaky". So we can remove this dependency.

@bkhouri bkhouri deleted the t/main/convert-AsyncFStests-and-more-to-swift-testing branch May 13, 2025 17:50
@bkhouri
Copy link
Contributor Author

bkhouri commented May 13, 2025

#8664 was posted to remove the Swift Numerics dependency. Thanks @drodriguez for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants