Remove Swift-numerics dependency #8664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `swift-numerics` package dependency was added to convert an XCTest `XCTAssertEqual(_:_:accuracy:_:file:line:)` API do use the `isApproximatelyEqual()` API in `swift-numerics`, but converting that test resulted in a flaky behaviour. As such, the test was not converted to Swift Testing, but the swift-numerics dependency remained. This change removes the swift-numerics dependency as it's no currently required.
bkhouri
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
jakepetroules
approved these changes
May 13, 2025
drodriguez
approved these changes
May 13, 2025
dschaefer2
approved these changes
May 13, 2025
|
Force merging to unblock CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
swift-numericspackage dependency was added to convert an XCTestXCTAssertEqual(_:_:accuracy:_:file:line:)API do use theisApproximatelyEqual()API inswift-numerics, but converting that test resulted in a flaky behaviour. As such, the test was not converted to Swift Testing, but the swift-numerics dependency remained.This change removes the swift-numerics dependency as it's no currently required.